On 6/8/20 6:54 PM, Paul Durrant wrote: >> -----Original Message----- >> From: Philippe Mathieu-Daudé <phi...@redhat.com> >> >> This code hasn't been QOM'ified yet. Warn the user. > > "Based on today's IRC chat, this is a trivial RFC series > to anotate pre-qdev/QOM devices so developers using them > without knowing they are not QOM'ified yet can realize > it and convert them if they have time." > > So, how should this be coded then? The XenIOState doesn't really qualify as a > 'device', does it?
There is a pending question whether Machines are Devices or not. Xen is a tricky case, it is created as a Q35 machine overloaded with Xen features. >> @@ -1401,6 +1401,8 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion >> **ram_memory) >> xen_pfn_t ioreq_pfn; >> XenIOState *state; >> >> + qdev_warn_deprecated_function_used(); >> + >> state = g_malloc0(sizeof (XenIOState)); XenIOState is indeed not a device, it is allocated once, we won't gain anything making it a QOM object... so this patch is incorrect. Sorry for the noise :S Regards, Phil. >> >> state->xce_handle = xenevtchn_open(NULL, 0); >> -- >> 2.21.3 > >
