On 6/9/20 6:13 PM, Peter Xu wrote:
> On Tue, Jun 09, 2020 at 11:49:49AM -0400, Michael S. Tsirkin wrote:
>>>>>> @@ -417,8 +419,8 @@
>>>>>> { 'struct': 'PciDeviceInfo',
>>>>>> 'data': {'bus': 'int', 'slot': 'int', 'function': 'int',
>>>>>> 'class_info': 'PciDeviceClass', 'id': 'PciDeviceId',
>>>>>> - '*irq': 'int', 'qdev_id': 'str', '*pci_bridge':
>>>>>> 'PciBridgeInfo',
>>>>>> - 'regions': ['PciMemoryRegion']} }
>>>>>> + '*irq': 'int', 'irq_pin': 'int', 'qdev_id': 'str',
>>>>>> + '*pci_bridge': 'PciBridgeInfo', 'regions':
>>>>>> ['PciMemoryRegion'] }}
>>>>>
>>>>> and the pre-existing pci_bridge is indeed the consistency issue.
>>>>
>>>> Yeh, actually every key in this struct. :)
>>>
>>> Using 'irq-pin':
>>> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
>>
>>
>> Peter can you fix and repost pls?
>
> I still think irq_pin is better because as I mentioned previously all the
> existing keys are using underscores... Phil?
No problem!
