On 6/9/20 9:02 AM, Peter Maydell wrote:
+#define DO_PREWIDEN(INSN, S, EXT, OP, SRC1WIDE) \
> + static bool trans_##INSN##_3d(DisasContext *s, arg_3diff *a) \
> + { \
> + NeonGenWidenFn *widenfn[] = { \
> + gen_helper_neon_widen_##S##8, \
> + gen_helper_neon_widen_##S##16, \
> + tcg_gen_##EXT##_i32_i64, \
> + NULL, \
> + }; \
> + NeonGenTwo64OpFn *addfn[] = { \
Missing const here.
Actually, patch 1 made me look back and we missed it, and static, in
trans_VSHLL_*_2sh.
Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
