On 10.06.20 09:51, David Hildenbrand wrote: > Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json > parser, making it possible to specify complex types. However, with this > change it is no longer possible to specify proper sizes (e.g., 2G, 128M), > turning the interface harder to use for properties that consume sizes. > > Let's switch back to the previous handling and allow to specify passing > json via the "-j" parameter. > > Cc: Philippe Mathieu-Daudé <phi...@redhat.com> > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: "Daniel P. Berrangé" <berra...@redhat.com> > Cc: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > v1 - v2: > - keep the "value:S" as correctly noted by Paolo :) > --- > hmp-commands.hx | 7 ++++--- > qom/qom-hmp-cmds.c | 20 ++++++++++++++++---- > 2 files changed, 20 insertions(+), 7 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 28256209b5..5d12fbeebe 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1806,9 +1806,10 @@ ERST > > { > .name = "qom-set", > - .args_type = "path:s,property:s,value:S", > - .params = "path property value", > - .help = "set QOM property", > + .args_type = "json:-j,path:s,property:s,value:S", > + .params = "[-j] path property value", > + .help = "set QOM property.\n\t\t\t" > + "-j: the property is specified in json format.",
Stupid mistake: "-j: the value is specified in json format -- Thanks, David / dhildenb