On 10/06/2020 13.08, Aleksandar Markovic wrote: > пон, 8. јун 2020. у 11:05 Philippe Mathieu-Daudé <f4...@amsat.org> је > написао/ла: >> >> Aurelien Jarno expressed his desire to orphan the SH4 hardware [*]: >> >> I don't mind being [...] removed from there. >> I do not really have time to work on that. >> >> Mark the SH4 emulated hardware orphan. >> >> Many thanks to Aurelien for his substantial contributions to QEMU, >> and for maintaining the SH4 hardware for various years! >> >> [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708400.html >> >> Message-Id: <20200601214125.ga1924...@aurel32.net> >> Acked-by: Aurelien Jarno <aurel...@aurel32.net> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- > > The basic idea of the patch (as read from the title and the commit > message) is good and positive. > > The problem is that the patch does something different than the commit > message says - pretending that it just orphans something. Which is not > good. Actually, very clumsy and bad.
Aleksandar, could you please stop being so negative? If you've got issues with a patch, that's fair, but you can then also simply express your opinion in a professional and constructive way. Calling the work of someone else "clumsy" is really not something that I want to read on the qemu-devel mailing list. Thanks, Thomas
