On Wed, Jun 10, 2020 at 10:54:26AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 10, 2020 at 01:40:02PM +0200, Igor Mammedov wrote: > > On Wed, 10 Jun 2020 11:41:22 +0200 > > Gerd Hoffmann <kra...@redhat.com> wrote: > > > > > First batch of microvm patches, some generic acpi stuff. > > > Split the acpi-build.c monster, specifically split the > > > pc and q35 and pci bits into a separate file which we > > > can skip building at some point in the future. > > > > > It looks like series is missing patch to whitelist changed ACPI tables in > > bios-table-test. > > Right. Does it pass make check?
No, but after 'git cherry-pick 9b20a3365d73dad4ad144eab9c5827dbbb2e9f21' it does. > > Do we already have test case for microvm in bios-table-test, > > if not it's probably time to add it. > > Separately :) Especially as this series is just preparing cleanups and doesn't actually add acpi support to microvm yet. But, yes, adding a testcase sounds useful. take care, Gerd
