On Sat, 6 Jun 2020 at 10:03, Erik Smit <erik.lucas.s...@gmail.com> wrote: > > The hardware supports configurable descriptor sizes, configured in the DBLAC > register. > > Most drivers use the default 4 word descriptor, which is currently hardcoded, > but Aspeed SDK configures 8 words to store extra data.
Hi; I've applied this to target-arm.next, with the parenthesis change that Cédric suggested; thanks for your contribution. A couple of minor patch format notes, which are only worth worrying about if you plan to submit more QEMU patches in future: > --- The Signed-off-by: line should go above this '---' divider, because it wants to go into the commit message in git; anything below '---' is discarded when the patch is applied. > /* > * PHY control register > */ > @@ -553,7 +563,7 @@ static void ftgmac100_do_tx(FTGMAC100State *s, > uint32_t tx_ring, Your email client is wrapping long lines, which corrupts patches. (You can see that patchew was unable to apply and CI-test it: https://patchew.org/QEMU/CA+MHfovYq1UAQQ341MnyGas7ScskWyjR=qe0d-rs7+zxf2m...@mail.gmail.com/ ) I fixed this patch up by hand, but if you're planning on sending more patches in future it would be worth sorting out how to send them in a way that doesn't wrap them. (Most long-term devs use some form of the 'git send-email' client.) thanks -- PMM
