On Mon, 15 Jun 2020, Peter Maydell wrote:
On Sat, 6 Jun 2020 at 20:22, BALATON Zoltan <bala...@eik.bme.hu> wrote:
Some guests seem to try source copy blits with same source and dest
which are no-op so avoid calling pixman for these.
Are they doing actual source copy blits, or one of the other
currently-unimplemented op types which we currently fall
back to doing as source-copy ?
I thought the same but in the cases I've seen the rop was 0xcc which is
copy source so it looks like an actual source copy blit (this seems to be
an issue in the guest driver, I've notified appropriate people but not
sure it's still maintained). Even if it was fallback we wouldn't need to
do the copy in this case as it changes nothing so we can optimise this
out. When we implement the missing op that would come before this case so
this is only for source copy case.
Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Thank you,
BALATON Zoltan