On 6/16/20 7:15 PM, Cédric Le Goater wrote: > After a closer look, > >>> @@ -45,9 +46,15 @@ static void pca9552_update_pin_input(PCA9552State *s) >>> switch (config) { >>> case PCA9552_LED_ON: >>> s->regs[input_reg] |= 1 << input_shift; >>> + if (input_shift < s->nr_leds) { > This seems like a superfluous test.
Indeed. > >>> + trace_pca9552_led_set(input_shift, true); > > This should be using 'i' and the output is not very concise : > > 564609@1592326881.815616:pca9552_led_set LED#0 state:1 > 564609@1592326881.815660:pca9552_led_set LED#1 state:1 > 564609@1592326881.815669:pca9552_led_set LED#2 state:1 > 564609@1592326881.815677:pca9552_led_set LED#3 state:1 > 564609@1592326881.815706:pca9552_led_set LED#4 state:0 > 564609@1592326881.815715:pca9552_led_set LED#5 state:0 > 564609@1592326881.815727:pca9552_led_set LED#6 state:0 > 564609@1592326881.815740:pca9552_led_set LED#7 state:0 > 564609@1592326881.815748:pca9552_led_set LED#8 state:0 > 564609@1592326881.815759:pca9552_led_set LED#9 state:0 > 564609@1592326881.815767:pca9552_led_set LED#10 state:0 > 564609@1592326881.815779:pca9552_led_set LED#11 state:0 > 564609@1592326881.815790:pca9552_led_set LED#12 state:0 > 564609@1592326881.815802:pca9552_led_set LED#13 state:1 > 564609@1592326881.815813:pca9552_led_set LED#14 state:1 > 564609@1592326881.815826:pca9552_led_set LED#15 state:1 > > I would instead simply dump the contents of the PCA9552_INPUT registers : > > LEDS = 1111000000000101 > LEDS = 1111000000000111 > .... Good idea, thanks! > > C. > > >>> + } >>> break; >>> case PCA9552_LED_OFF: >>> s->regs[input_reg] &= ~(1 << input_shift); >>> + if (input_shift < s->nr_leds) { >>> + trace_pca9552_led_set(input_shift, false); >>> + } >>> break; >>> case PCA9552_LED_PWM0: >>> case PCA9552_LED_PWM1: >>> diff --git a/hw/misc/trace-events b/hw/misc/trace-events >>> index 5561746866..ed80d0d1be 100644 >>> --- a/hw/misc/trace-events >>> +++ b/hw/misc/trace-events >>> @@ -206,3 +206,6 @@ via1_rtc_cmd_pram_sect_write(int sector, int offset, >>> int addr, int value) "secto >>> # grlib_ahb_apb_pnp.c >>> grlib_ahb_pnp_read(uint64_t addr, uint32_t value) "AHB PnP read >>> addr:0x%03"PRIx64" data:0x%08x" >>> grlib_apb_pnp_read(uint64_t addr, uint32_t value) "APB PnP read >>> addr:0x%03"PRIx64" data:0x%08x" >>> + >>> +# pca9552.c >>> +pca9552_led_set(unsigned id, bool state) "LED#%d state:%u" >>> >> > >