On 6/17/20 7:39 AM, P J P wrote:
> From: Prasad J Pandit <p...@fedoraproject.org>
>
> Add vfio quirk device mmio write method to avoid NULL pointer
> dereference issue.
>
> Reported-by: Lei Sun <slei.cas...@gmail.com>
> Signed-off-by: Prasad J Pandit <p...@fedoraproject.org>
> ---
> hw/vfio/pci-quirks.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> index f2155ddb1d..5bd98885d5 100644
> --- a/hw/vfio/pci-quirks.c
> +++ b/hw/vfio/pci-quirks.c
> @@ -13,6 +13,7 @@
> #include "qemu/osdep.h"
> #include "exec/memop.h"
> #include "qemu/units.h"
> +#include "qemu/log.h"
> #include "qemu/error-report.h"
> #include "qemu/main-loop.h"
> #include "qemu/module.h"
> @@ -263,8 +264,15 @@ static uint64_t vfio_ati_3c3_quirk_read(void *opaque,
> return data;
> }
>
> +static void vfio_ati_3c3_quirk_write(void *opaque, hwaddr addr,
> + uint64_t data, unsigned size)
> +{
> + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
Shouldn't this be LOG_GUEST_ERROR?
> +}
> +
> static const MemoryRegionOps vfio_ati_3c3_quirk = {
> .read = vfio_ati_3c3_quirk_read,
> + .write = vfio_ati_3c3_quirk_write,
> .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
>
