On 17.06.20 16:19, Kevin Wolf wrote: > Am 17.06.2020 um 16:11 hat Max Reitz geschrieben: >> On 17.06.20 14:52, Kevin Wolf wrote: >>> Am 17.06.2020 um 12:48 hat Max Reitz geschrieben: >>>> Hi, >>>> >>>> Thomas’s report >>>> (https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00791.html) >>>> has given me a nice excuse to write this series. >>>> >>>> There are some iotests that have recently start to fail in rarely >>>> exercised test environments (qed, qcow2 with data_file, qcow2 v2), and >>>> this series fixes what I found. >>> >>> Thanks, applied to the block branch. >> >> Sorry, I didn’t run iotest 297 before sending this series... >> >> The problems arise in patch 1: >> >> iotests.py:1113:0: C0301: Line too long (80/79) (line-too-long) >> iotests.py:1106: error: Function is missing a return type annotation >> >> (So there’s a line with 80 characters, when 79 is the maximum (*shrug*), >> and I failed to specify skip_for_format’s return type.) >> >> I think patch 1 needs the attached diff squashed in. Are you willing to >> do that or should I just send a v2? > > I'm squashing it in. In fact, I already had fixed it, but I was too lazy > to be more specific than Callable[..., Any], so I'll replace that with > your version.
I have to admit I was intrigued to see how the actual signature would turn out, so I followed it through until the biter end. :) Thanks!
signature.asc
Description: OpenPGP digital signature
