On 6/19/20 7:15 PM, Peter Maydell wrote:
> In commit cfdb2c0c95ae9205b0 ("target/arm: Vectorize SABA/UABA") we
> replaced the old handling of SABA/UABA with a vectorized implementation
> which returns early rather than falling into the loop-ever-elements
> code. We forgot to delete the part of the old looping code that
> did the accumulate step, and Coverity correctly warns (CID 1428955)
> that this code is now dead. Delete it.
>
> Fixes: cfdb2c0c95ae9205b0
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> target/arm/translate-a64.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index a0e72ad6942..01d59164d68 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -11370,18 +11370,6 @@ static void disas_simd_3same_int(DisasContext *s,
> uint32_t insn)
> genfn(tcg_res, tcg_op1, tcg_op2);
> }
>
> - if (opcode == 0xf) {
> - /* SABA, UABA: accumulating ops */
> - static NeonGenTwoOpFn * const fns[3] = {
> - gen_helper_neon_add_u8,
> - gen_helper_neon_add_u16,
> - tcg_gen_add_i32,
> - };
> -
> - read_vec_element_i32(s, tcg_op1, rd, pass, MO_32);
> - fns[size](tcg_res, tcg_op1, tcg_res);
> - }
> -
> write_vec_element_i32(s, tcg_res, rd, pass, MO_32);
>
> tcg_temp_free_i32(tcg_res);
>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
