уторак, 23. јун 2020., <no-re...@patchew.org> је написао/ла:
> Patchew URL: https://patchew.org/QEMU/1592914438-30317-1-git-send- > email-che...@lemote.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Hi, Huacai. Please fix all checkpatch warnings in the next version (except thise that complain about the need for updating MAONTAINERS) Also, you dont need " for-5.1" in subject prefixes. Please fix these and other small things that I commented about, and send v6 soon (tomorrow, if possible?), so that we remove these small obstacles and focus on the core functionality of tge series. Thanks, Aleksandar > Subject: [PATCH for-5.1 V5 0/4] mips: Add Loongson-3 machine support (with > KVM) > Type: series > Message-id: 1592914438-30317-1-git-send-email-che...@lemote.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > From https://github.com/patchew-project/qemu > * [new tag] patchew/1592914438-30317-1- > git-send-email-che...@lemote.com -> patchew/1592914438-30317-1- > git-send-email-che...@lemote.com > Switched to a new branch 'test' > 63e13a2 MAINTAINERS: Add Loongson-3 maintainer and reviewer > 727fa14 hw/mips: Add Loongson-3 machine support (with KVM) > 5fd21a0 hw/intc: Add Loongson liointc support > 6996d49 hw/mips: Implement the kvm_type() hook in MachineClass > > === OUTPUT BEGIN === > 1/4 Checking commit 6996d492ec71 (hw/mips: Implement the kvm_type() hook > in MachineClass) > 2/4 Checking commit 5fd21a0bcd83 (hw/intc: Add Loongson liointc support) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #36: > new file mode 100644 > > ERROR: line over 90 characters > #90: FILE: hw/intc/loongson_liointc.c:50: > +#define LOONGSON_LIOINTC(obj) OBJECT_CHECK(struct loongson_liointc, > (obj), TYPE_LOONGSON_LIOINTC) > > ERROR: open brace '{' following struct go on the same line > #93: FILE: hw/intc/loongson_liointc.c:53: > +struct loongson_liointc > +{ > > ERROR: code indent should never use tabs > #148: FILE: hw/intc/loongson_liointc.c:108: > +^I if (p->parent_state[parent] !=$ > > total: 3 errors, 1 warnings, 256 lines checked > > Patch 2/4 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 3/4 Checking commit 727fa142abed (hw/mips: Add Loongson-3 machine support > (with KVM)) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #84: > new file mode 100644 > > WARNING: line over 80 characters > #404: FILE: hw/mips/loongson3_virt.c:316: > +static void loongson3_pm_write(void *opaque, hwaddr addr, uint64_t val, > unsigned size) > > WARNING: line over 80 characters > #704: FILE: hw/mips/loongson3_virt.c:616: > + fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)current_machine-> > smp.max_cpus); > > WARNING: line over 80 characters > #840: FILE: hw/mips/loongson3_virt.c:752: > +static inline void loongson3_virt_devices_init(MachineState *machine, > DeviceState *pic) > > WARNING: line over 80 characters > #871: FILE: hw/mips/loongson3_virt.c:783: > + get_system_io(), 0, > virt_memmap[VIRT_PCIE_PIO].size); > > WARNING: line over 80 characters > #977: FILE: hw/mips/loongson3_virt.c:889: > + /* Allocate RAM/BIOS, 0x00000000~0x10000000 is alias of > 0x80000000~0x90000000 */ > > total: 0 errors, 6 warnings, 999 lines checked > > Patch 3/4 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 4/4 Checking commit 63e13a297290 (MAINTAINERS: Add Loongson-3 maintainer > and reviewer) > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/1592914438-30317-1-git-send- > email-che...@lemote.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com
