On 6/24/20 11:43 AM, Markus Armbruster wrote:
opt_set() frees its argument @value on failure. Slightly unclean; functions ideally do nothing on failure.To tidy this up, move opt_create() from opt_set() into its callers, along with the cleanup. Signed-off-by: Markus Armbruster <arm...@redhat.com> --- util/qemu-option.c | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index 3cdf0c0800..14946e81f2 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -519,36 +519,39 @@ static QemuOpt *opt_create(QemuOpts *opts, const char *name, char *value, return opt; }
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
