On Thu, Jun 25, 2020 at 08:48:27PM +0200, Philippe Mathieu-Daudé wrote: > qemu_try_blockalign() is a generic API that call back to the > block driver to return its page alignment. As we call from > within the very same driver, we already know to page alignment > stored in our state. Remove indirections and use the value from > BDRVNVMeState.
The higher-level qemu_try_blockalign() API does not require all callers to be aware of the memory alignment details. It seems like a disadvantage to duplicate that knowledge throughout the code, even if it's in the same driver source code. Is there an advantage to this patch that I've missed?
signature.asc
Description: PGP signature
