Patchew URL: https://patchew.org/QEMU/20200626124612.58593-1-mky...@tachyum.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3 0/2] linux-user: support of semtimedop syscall Type: series Message-id: 20200626124612.58593-1-mky...@tachyum.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 611ac63..10f7ffa master -> master * [new tag] patchew/1593177220-28143-1-git-send-email-bmeng...@gmail.com -> patchew/1593177220-28143-1-git-send-email-bmeng...@gmail.com - [tag update] patchew/20200625184838.28172-1-phi...@redhat.com -> patchew/20200625184838.28172-1-phi...@redhat.com - [tag update] patchew/20200626033144.790098-1-richard.hender...@linaro.org -> patchew/20200626033144.790098-1-richard.hender...@linaro.org - [tag update] patchew/20200626092317.3875-1-mark.cave-ayl...@ilande.co.uk -> patchew/20200626092317.3875-1-mark.cave-ayl...@ilande.co.uk * [new tag] patchew/20200626124612.58593-1-mky...@tachyum.com -> patchew/20200626124612.58593-1-mky...@tachyum.com * [new tag] patchew/20200626130658.76498-1-vsement...@virtuozzo.com -> patchew/20200626130658.76498-1-vsement...@virtuozzo.com - [tag update] patchew/cover.1592315226.git.bala...@eik.bme.hu -> patchew/cover.1592315226.git.bala...@eik.bme.hu Switched to a new branch 'test' 9b6fb16 linux-user: support of semtimedop syscall 230a3ca linux-user: refactor ipc syscall === OUTPUT BEGIN === 1/2 Checking commit 230a3cadaac4 (linux-user: refactor ipc syscall) WARNING: architecture specific defines should be avoided #20: FILE: linux-user/syscall.c:817: +#ifdef __s390x__ WARNING: architecture specific defines should be avoided #35: FILE: linux-user/syscall.c:4061: +#ifdef __s390x__ WARNING: architecture specific defines should be avoided #49: FILE: linux-user/syscall.c:4076: +#ifdef __NR_ipc WARNING: architecture specific defines should be avoided #50: FILE: linux-user/syscall.c:4077: +#if defined(__sparc__) ERROR: Macros with complex values should be enclosed in parenthesis #52: FILE: linux-user/syscall.c:4079: +#define MSGRCV_ARGS(__msgp, __msgtyp) __msgp, __msgtyp ERROR: Macros with complex values should be enclosed in parenthesis #58: FILE: linux-user/syscall.c:4085: +#define MSGRCV_ARGS(__msgp, __msgtyp) \ + ((long int[]){(long int)__msgp, __msgtyp}), 0 total: 2 errors, 4 warnings, 55 lines checked Patch 1/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/2 Checking commit 9b6fb16d5bb7 (linux-user: support of semtimedop syscall) WARNING: architecture specific defines should be avoided #40: FILE: linux-user/syscall.c:3891: +#ifdef __s390x__ ERROR: Macros with complex values should be enclosed in parenthesis #41: FILE: linux-user/syscall.c:3892: +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ + (__nsops), (__timeout), (__sops) ERROR: Macros with complex values should be enclosed in parenthesis #44: FILE: linux-user/syscall.c:3895: +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ + (__nsops), 0, (__sops), (__timeout) total: 2 errors, 1 warnings, 98 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200626124612.58593-1-mky...@tachyum.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com