Re: [Qemu-devel] [PATCH 05/28] PPC: Set MPIC IDE for IPI to 0

[Elie Richa]

On 07/23/2011 12:49 PM, Alexander Graf wrote:

@@ -1304,6 +1304,10 @@ static void mpic_reset (void *opaque)
          mpp->src[i].ipvp = 0x80800000;
          mpp->src[i].ide  = 0x00000001;
      }
+    /* Set IDE for IPIs to 0 so we don't get spurious interrupts */
+    for (i = mpp->irq_ipi0; i<  MAX_IPI; i++) {

I suppose you meant i < mpp->irq_ipi0 + MAX_IPI in that loop condition right? ;)

+        mpp->src[i].ide = 0;
+    }
      /* Initialise IRQ destinations */
      for (i = 0; i<  MAX_CPU; i++) {
          mpp->dst[i].pctp      = 0x0000000F;