On Fri, Jun 26, 2020 at 04:02:43PM +0200, Philippe Mathieu-Daudé wrote: > On 6/26/20 12:36 PM, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2020 at 08:48:22PM +0200, Philippe Mathieu-Daudé wrote: > >> Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is > >> not enabled. > > > > Why? > > > > This saves 8 trace events, each with 8 arguments. I guess the intent is > > to improve performance. Did you measure an improvement? > > No testing, I just tried to outsmart the compiler :/
Usually performance patches are accompanied with benchmark results. Otherwise it's easy to modify code without making a difference or accidentally introducing performance regressions. But this is a small change and I'm not worried. Please do explicitly state in the commit description that this is intended as a performance optimization. I wasn't exactly sure about the reason for this change. Stefan
signature.asc
Description: PGP signature
