Patchew URL: https://patchew.org/QEMU/20200703100650.621212-1-coh...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/14] s390x update Type: series Message-id: 20200703100650.621212-1-coh...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' eba5a5a s390x/pci: fix set_ind_atomic 67b11c1 virtio-ccw: fix virtio_set_ind_atomic fdc71f8 target/s390x: Fix SQXBR f966c19 pc-bios/s390: Update s390-ccw bios binaries with the latest changes d498e85 pc-bios/s390-ccw: Generate and include dependency files in the Makefile cf42370 pc-bios: s390x: Make u32 ptr check explicit 30a3146 pc-bios: s390x: Use ebcdic2ascii table 6a8838f pc-bios: s390x: Move panic() into header and add infinite loop c621fd2 pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR 0ac5009 pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64 e3d2538 pc-bios: s390x: Get rid of magic offsets into the lowcore 88b7b59 pc-bios: s390x: Move sleep and yield to helper.h 3aabf1e pc-bios: s390x: Consolidate timing functions into time.h b3f76f4 pc-bios: s390x: cio.c cleanup and compile fix === OUTPUT BEGIN === 1/14 Checking commit b3f76f4ecf8f (pc-bios: s390x: cio.c cleanup and compile fix) 2/14 Checking commit 3aabf1ef14b2 (pc-bios: s390x: Consolidate timing functions into time.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #97: new file mode 100644 total: 0 errors, 1 warnings, 142 lines checked Patch 2/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/14 Checking commit 88b7b59bf3c7 (pc-bios: s390x: Move sleep and yield to helper.h) 4/14 Checking commit e3d2538969d3 (pc-bios: s390x: Get rid of magic offsets into the lowcore) ERROR: spaces required around that ':' (ctx:VxV) #34: FILE: pc-bios/s390-ccw/cio.h:127: + __u16 cssid:8; ^ ERROR: spaces required around that ':' (ctx:VxV) #35: FILE: pc-bios/s390-ccw/cio.h:128: + __u16 reserved:4; ^ ERROR: spaces required around that ':' (ctx:VxV) #36: FILE: pc-bios/s390-ccw/cio.h:129: + __u16 m:1; ^ ERROR: spaces required around that ':' (ctx:VxV) #37: FILE: pc-bios/s390-ccw/cio.h:130: + __u16 ssid:2; ^ ERROR: spaces required around that ':' (ctx:VxV) #38: FILE: pc-bios/s390-ccw/cio.h:131: + __u16 one:1; ^ total: 5 errors, 0 warnings, 37 lines checked Patch 4/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/14 Checking commit 0ac50090511a (pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64) 6/14 Checking commit c621fd21564a (pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR) 7/14 Checking commit 6a8838f0e407 (pc-bios: s390x: Move panic() into header and add infinite loop) 8/14 Checking commit 30a314650aac (pc-bios: s390x: Use ebcdic2ascii table) 9/14 Checking commit cf423705626a (pc-bios: s390x: Make u32 ptr check explicit) 10/14 Checking commit d498e85da28d (pc-bios/s390-ccw: Generate and include dependency files in the Makefile) 11/14 Checking commit f966c19345d4 (pc-bios/s390: Update s390-ccw bios binaries with the latest changes) 12/14 Checking commit fdc71f8c35d6 (target/s390x: Fix SQXBR) 13/14 Checking commit 67b11c11ffb3 (virtio-ccw: fix virtio_set_ind_atomic) 14/14 Checking commit eba5a5a6540b (s390x/pci: fix set_ind_atomic) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200703100650.621212-1-coh...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com