On 04/07/2020 11.23, Peter Maydell wrote: > In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header > so that it was always included from .c files and never from other .h files. > We missed adding it to net/tap-solaris.c (which previously was pulling it > in via tap-int.h), which broke building on Solaris hosts. > > Fixes: a8d2532645cf5ce4 > Reported-by: Michele Denber <den...@mindspring.com> > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Untested: Michele, could you give this a try? > --- > net/tap-solaris.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/tap-solaris.c b/net/tap-solaris.c > index 4725d2314ee..d03165c57c9 100644 > --- a/net/tap-solaris.c > +++ b/net/tap-solaris.c > @@ -27,6 +27,7 @@ > #include "tap_int.h" > #include "qemu/ctype.h" > #include "qemu/cutils.h" > +#include "qemu-common.h" > > #include <sys/ethernet.h> > #include <sys/sockio.h> >
Reviewed-by: Thomas Huth <th...@redhat.com>
