On Sun, Jul 5, 2020 at 11:16 AM Max Filippov <jcmvb...@gmail.com> wrote: > On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell <peter.mayd...@linaro.org> > wrote: > > On Thu, 2 Jul 2020 at 19:53, Richard Henderson > > <richard.hender...@linaro.org> wrote: > > > This isn't right. Not so much the gen_io_start portion, but the entire > > > existence of helper_check_interrupt. > > I agree that it looks bogus (xtensa has a similar helper as well, > > incidentally), > I think there was a reason for it.
...and the reason is that this helper calls cpu_[re]set_interrupt to update CPU_INTERRUPT_HARD, which makes exit to the main CPU loop do something to handle IRQ. Maybe 'check_interrupt' is not a good name for that, but the action taken there seems right to me. -- Thanks. -- Max
