Patchew URL: https://patchew.org/QEMU/20200706100432.2301919-1-mre...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/31] Block patches Type: series Message-id: 20200706100432.2301919-1-mre...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200706100432.2301919-1-mre...@redhat.com -> patchew/20200706100432.2301919-1-mre...@redhat.com Switched to a new branch 'test' 61a6805 qed: Simplify backing reads 8160191 block: drop unallocated_blocks_are_zero d59b973 block/vhdx: drop unallocated_blocks_are_zero fc425f8 block/file-posix: drop unallocated_blocks_are_zero ee4e5f6 block/iscsi: drop unallocated_blocks_are_zero 9aacd22 block/crypto: drop unallocated_blocks_are_zero 4d6c6ad block/vpc: return ZERO block-status when appropriate 42d9c04 block/vdi: return ZERO block-status when appropriate f73a13e block: inline bdrv_unallocated_blocks_are_zero() d5d6d75 qemu-img: convert: don't use unallocated_blocks_are_zero ecc887e iotests: add tests for blockdev-amend ee66938 block/qcow2: implement blockdev-amend 9254299 block/crypto: implement blockdev-amend f905f40 block/core: add generic infrastructure for x-blockdev-amend qmp command 5737d94 iotests: qemu-img tests for luks key management 1981eea block/qcow2: extend qemu-img amend interface with crypto options 75ebd25 block/crypto: implement the encryption key management 381affe block/crypto: rename two functions 37d5645 block/amend: refactor qcow2 amend options 2057114 block/amend: separate amend and create options for qemu-img 01ead3a block/amend: add 'force' option 23c67be qcrypto/luks: implement encryption key management 255ed50 qcrypto/core: add generic infrastructure for crypto options amendment 2267d63 iotests: Check whether luks works a28c683 iotests.py: Add (verify|has)_working_luks() e4821d5 iotests.py: Add qemu_img_pipe_and_status() e9500aa iotests/common.rc: Add _require_working_luks b3b46b5 iotests: filter few more luks specific create options f872aeb iotests: Make _filter_img_create more active d327a4c qcow2: Fix preallocation on images with unaligned sizes 9e289b8 block/block-copy: block_copy_dirty_clusters: fix failure check === OUTPUT BEGIN === 1/31 Checking commit 9e289b8e0d77 (block/block-copy: block_copy_dirty_clusters: fix failure check) 2/31 Checking commit d327a4c43167 (qcow2: Fix preallocation on images with unaligned sizes) 3/31 Checking commit f872aebcf148 (iotests: Make _filter_img_create more active) 4/31 Checking commit b3b46b52bfec (iotests: filter few more luks specific create options) 5/31 Checking commit e9500aa71b58 (iotests/common.rc: Add _require_working_luks) 6/31 Checking commit e4821d5b92da (iotests.py: Add qemu_img_pipe_and_status()) 7/31 Checking commit a28c683849bf (iotests.py: Add (verify|has)_working_luks()) 8/31 Checking commit 2267d63fda82 (iotests: Check whether luks works) 9/31 Checking commit 255ed5095c89 (qcrypto/core: add generic infrastructure for crypto options amendment) 10/31 Checking commit 23c67bedd6e4 (qcrypto/luks: implement encryption key management) 11/31 Checking commit 01ead3a1b6b0 (block/amend: add 'force' option) 12/31 Checking commit 2057114b7a98 (block/amend: separate amend and create options for qemu-img) ERROR: Macros with multiple statements should be enclosed in a do - while loop #34: FILE: block/qcow2.c:5663: +#define QCOW_COMMON_OPTIONS \ + { \ + .name = BLOCK_OPT_SIZE, \ + .type = QEMU_OPT_SIZE, \ + .help = "Virtual disk size" \ + }, \ + { \ + .name = BLOCK_OPT_COMPAT_LEVEL, \ + .type = QEMU_OPT_STRING, \ + .help = "Compatibility level (v2 [0.10] or v3 [1.1])" \ + }, \ + { \ + .name = BLOCK_OPT_BACKING_FILE, \ + .type = QEMU_OPT_STRING, \ + .help = "File name of a base image" \ + }, \ + { \ + .name = BLOCK_OPT_BACKING_FMT, \ + .type = QEMU_OPT_STRING, \ + .help = "Image format of the base image" \ + }, \ + { \ + .name = BLOCK_OPT_DATA_FILE, \ + .type = QEMU_OPT_STRING, \ + .help = "File name of an external data file" \ + }, \ + { \ + .name = BLOCK_OPT_DATA_FILE_RAW, \ + .type = QEMU_OPT_BOOL, \ + .help = "The external data file must stay valid " \ + "as a raw image" \ + }, \ + { \ + .name = BLOCK_OPT_ENCRYPT, \ + .type = QEMU_OPT_BOOL, \ + .help = "Encrypt the image with format 'aes'. (Deprecated " \ + "in favor of " BLOCK_OPT_ENCRYPT_FORMAT "=aes)", \ + }, \ + { \ + .name = BLOCK_OPT_ENCRYPT_FORMAT, \ + .type = QEMU_OPT_STRING, \ + .help = "Encrypt the image, format choices: 'aes', 'luks'", \ + }, \ + BLOCK_CRYPTO_OPT_DEF_KEY_SECRET("encrypt.", \ + "ID of secret providing qcow AES key or LUKS passphrase"), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_CIPHER_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_CIPHER_MODE("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_IVGEN_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_IVGEN_HASH_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_HASH_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_ITER_TIME("encrypt."), \ + { \ + .name = BLOCK_OPT_CLUSTER_SIZE, \ + .type = QEMU_OPT_SIZE, \ + .help = "qcow2 cluster size", \ + .def_value_str = stringify(DEFAULT_CLUSTER_SIZE) \ + }, \ + { \ + .name = BLOCK_OPT_PREALLOC, \ + .type = QEMU_OPT_STRING, \ + .help = "Preallocation mode (allowed values: off, " \ + "metadata, falloc, full)" \ + }, \ + { \ + .name = BLOCK_OPT_LAZY_REFCOUNTS, \ + .type = QEMU_OPT_BOOL, \ + .help = "Postpone refcount updates", \ + .def_value_str = "off" \ + }, \ + { \ + .name = BLOCK_OPT_REFCOUNT_BITS, \ + .type = QEMU_OPT_NUMBER, \ + .help = "Width of a reference count entry in bits", \ + .def_value_str = "16" \ + }, \ + { \ + .name = BLOCK_OPT_COMPRESSION_TYPE, \ + .type = QEMU_OPT_STRING, \ + .help = "Compression method used for image cluster " \ + "compression", \ + .def_value_str = "zlib" \ + } total: 1 errors, 0 warnings, 244 lines checked Patch 12/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/31 Checking commit 37d5645c2d89 (block/amend: refactor qcow2 amend options) 14/31 Checking commit 381affeb1932 (block/crypto: rename two functions) 15/31 Checking commit 75ebd2518718 (block/crypto: implement the encryption key management) 16/31 Checking commit 1981eea00495 (block/qcow2: extend qemu-img amend interface with crypto options) 17/31 Checking commit 5737d9411ca1 (iotests: qemu-img tests for luks key management) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100755 total: 0 errors, 1 warnings, 433 lines checked Patch 17/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/31 Checking commit f905f403e917 (block/core: add generic infrastructure for x-blockdev-amend qmp command) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 total: 0 errors, 1 warnings, 221 lines checked Patch 18/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/31 Checking commit 925429913f58 (block/crypto: implement blockdev-amend) 20/31 Checking commit ee66938d1193 (block/qcow2: implement blockdev-amend) 21/31 Checking commit ecc887e8c0a4 (iotests: add tests for blockdev-amend) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100755 total: 0 errors, 1 warnings, 593 lines checked Patch 21/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/31 Checking commit d5d6d75d306c (qemu-img: convert: don't use unallocated_blocks_are_zero) 23/31 Checking commit f73a13e6c086 (block: inline bdrv_unallocated_blocks_are_zero()) 24/31 Checking commit 42d9c04825ab (block/vdi: return ZERO block-status when appropriate) 25/31 Checking commit 4d6c6ad7b389 (block/vpc: return ZERO block-status when appropriate) 26/31 Checking commit 9aacd22b62a4 (block/crypto: drop unallocated_blocks_are_zero) 27/31 Checking commit ee4e5f6a6804 (block/iscsi: drop unallocated_blocks_are_zero) 28/31 Checking commit fc425f8700a0 (block/file-posix: drop unallocated_blocks_are_zero) 29/31 Checking commit d59b973ebbed (block/vhdx: drop unallocated_blocks_are_zero) 30/31 Checking commit 816019134241 (block: drop unallocated_blocks_are_zero) 31/31 Checking commit 61a68058fcb1 (qed: Simplify backing reads) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200706100432.2301919-1-mre...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com