Hi Alistair, On Wed, Jul 8, 2020 at 1:33 AM Alistair Francis <alistai...@gmail.com> wrote: > > On Thu, Jul 2, 2020 at 6:25 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > On Wed, Jul 1, 2020 at 4:23 AM Alistair Francis > > <alistair.fran...@wdc.com> wrote: > > > > > > When a guest specificies the the rounding mode should be dynamic 0b111 > > > then we want to re-caclulate the rounding mode on each instruction. The > > > gen_helper_set_rounding_mode() function will correctly check the > > > rounding mode and handle a dynamic rounding, we just need to make sure > > > it's always called if dynamic rounding is selected. > > > > > > Fixes: 1885350 ("RISCV dynamic rounding mode is not behaving correctly") > > > > I can't find this commit id. > > It's a launchpad bug case: https://bugs.launchpad.net/qemu/+bug/1885350 >
My understanding is that the convention used in "Fixes" tag is for commit id. 1885350 is not a commit id but a QEMU bug report id. Regards, Bin