Daniel P. Berrangé <berra...@redhat.com> writes: > On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: >> There are a number of unnecessary trailing whitespaces that have >> accumulated over time in the source code. They cause stray changes >> in patches if you use tools that automatically remove them. >> >> Tested by doing a `git diff -w` after the change. >> >> This could probably be turned into a pre-commit hook.
See .git/hooks/pre-commit.sample. Expected test output is prone to flunk the whitespace test. One solution is to strip trailing whitespace from test output. > scripts/checkpatch.pl ought to be made to check it. > >> >> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> >> --- [...] >> 78 files changed, 440 insertions(+), 440 deletions(-) > > The cleanup is a good idea, however, I think it is probably better to > split the patch approx into subsystems. That will make it much easier > to cherry-pick for people doing backports. I doubt that's worth the trouble. Acked-by: Markus Armbruster <arm...@redhat.com>
