On Thu, Jul 09, 2020 at 11:02:24AM -0700, Raphael Norwitz wrote: > On Mon, Jul 6, 2020 at 7:00 AM Stefan Hajnoczi <stefa...@redhat.com> wrote: > > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c > > index a00b854736..39aec42dae 100644 > > --- a/hw/block/vhost-user-blk.c > > +++ b/hw/block/vhost-user-blk.c > > @@ -420,6 +420,9 @@ static void vhost_user_blk_device_realize(DeviceState > > *dev, Error **errp) > > return; > > } > > > > + if (s->num_queues == VHOST_USER_BLK_AUTO_NUM_QUEUES) { > > + s->num_queues = 1; > > + } > > What is this check for? Is it just a backstop to ensure that > num_queues is set to 1 if vhost-user-blk-pci doesn't update it?
For the non-PCI VIRTIO transports that do not handle num_queues == VHOST_USER_BLK_AUTO_NUM_QUEUES themselves. Stefan
signature.asc
Description: PGP signature