On 7/13/20 9:35 AM, Alex Bennée wrote:
>
> John Snow <js...@redhat.com> writes:
>
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>> MAINTAINERS | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6aa54f7f8f..fe1dcd5a76 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2280,11 +2280,18 @@ S: Maintained
>> F: include/sysemu/cryptodev*.h
>> F: backends/cryptodev*.c
>>
>> +Python library
>> +M: John Snow <js...@redhat.com>
>> +M: Cleber Rosa <cr...@redhat.com>
>> +R: Eduardo Habkost <ehabk...@redhat.com>
>> +S: Maintained
>> +F: python/*
>
> I don't think that's equivalent to what you drop bellow:
>
> F: drivers/net/ all files in and below drivers/net
> F: drivers/net/* all files in drivers/net, but not below
>
> So I think you should drop the *
>
>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>> Python scripts
>> M: Eduardo Habkost <ehabk...@redhat.com>
>> M: Cleber Rosa <cr...@redhat.com>
>> S: Odd fixes
>> -F: python/qemu/*py
>> F: scripts/*.py
>> F: tests/*.py
>
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
>
ACK on the edit, I think otherwise I'm still technically waiting for
Cleber to approve this before I would ask for someone to stage it.
--js
