Robert Foley <robert.fo...@linaro.org> writes:
> On Thu, 16 Jul 2020 at 07:07, Alex Bennée <alex.ben...@linaro.org> wrote: >> >> >> Robert Foley <robert.fo...@linaro.org> writes: >> >> > The changes to console_socket.py and machine.py are to >> > cleanup for pylint and flake8. >> > >> > Signed-off-by: Robert Foley <robert.fo...@linaro.org> >> > --- >> > python/qemu/console_socket.py | 58 +++++++++++++++++------------------ >> > python/qemu/machine.py | 7 +++-- >> > python/qemu/pylintrc | 2 +- >> > 3 files changed, 34 insertions(+), 33 deletions(-) >> > >> > diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py >> > index 830cb7c628..6a746c1dbf 100644 >> > --- a/python/qemu/console_socket.py >> > +++ b/python/qemu/console_socket.py >> > @@ -1,12 +1,9 @@ >> <snip> >> > @@ -103,7 +104,6 @@ class ConsoleSocket(asyncore.dispatcher): >> > >> > def set_blocking(self): >> > """Maintain compatibility with socket API""" >> > - pass >> >> Hmm shouldn't this be with the change in 2/2 because I thought you >> needed a "pass" for an empty function in python? > > Thanks for the review ! > > Sure, I can move this change to 2/2. Probably makes more sense there > since we're changing this function there too. > > This change was one of the suggestions from John Snow. > He pointed out that the pass is not needed here since the docstring takes > the role of the function body. Ahh I did not know you could do that... I'll defer to John's superior python knowledge. > > Thanks & Regards, > -Rob > >> >> Otherwise: >> >> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> >> >> -- >> Alex Bennée -- Alex Bennée