On 7/17/20 8:38 PM, Richard Henderson wrote: > On 7/17/20 11:17 AM, Philippe Mathieu-Daudé wrote: >> case MCH_HOST_BRIDGE_PCIEXBAR_LENGTH_RVD: >> - default: >> - abort(); >> + qemu_log_mask(LOG_GUEST_ERROR, "Q35: Reserved PCIEXBAR LENGTH\n"); >> + return; >> } > > Did you really want to remove the default case?
The field takes 2 bits, 3 cases are covered... > I guess the mask means that only *_RVD is left over, but the default sorta > self-documents that. OK I don't have problem keeping it - until a compiler start warning about it "default case already covered" ;) > > Either way, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Thanks! > > > r~ >
