On 7/23/20 2:42 PM, Eric Blake wrote:
On 7/17/20 3:14 AM, Andrey Shinkevich wrote:
Add dirty bitmap information to QCOW2 metadata dump in the
qcow2_format.py.
block/qcow2.c | 2 +-
docs/interop/qcow2.txt | 2 +-
tests/qemu-iotests/qcow2.py | 18 ++-
tests/qemu-iotests/qcow2_format.py | 221
++++++++++++++++++++++++++++++++++---
4 files changed, 220 insertions(+), 23 deletions(-)
I still don't see any obvious coverage of the new output, which makes it
harder to test (I have to manually run qcow2.py on a file rather than
seeing what changes in a ???.out file). I know we said back in v9 that
test 291 is not the right test, but that does not stop you from adding a
new test just for that purpose.
The bulk of this series is touching a non-installed utility. At this
point, I feel safer deferring it to 5.2 (it is a feature addition for
testsuite use only, and we missed soft freeze), even though it has no
negative impact to installed binaries.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
