On Jul 29 21:31, Maxim Levitsky wrote: > On Thu, 2020-07-30 at 00:52 +0900, Minwoo Im wrote: > > Klaus, > > > > On 20-07-20 13:37:39, Klaus Jensen wrote: > > > From: Klaus Jensen <k.jen...@samsung.com> > > > > > > Introduce the nvme_map helper to remove some noise in the main nvme_rw > > > function. > > > > > > Signed-off-by: Klaus Jensen <k.jen...@samsung.com> > > > Reviewed-by: Maxim Levitsky <mlevi...@redhat.com> > > > --- > > > hw/block/nvme.c | 13 ++++++++++--- > > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > > index f1e04608804b..68c33a11c144 100644 > > > --- a/hw/block/nvme.c > > > +++ b/hw/block/nvme.c > > > @@ -413,6 +413,15 @@ static uint16_t nvme_dma_prp(NvmeCtrl *n, uint8_t > > > *ptr, uint32_t len, > > > return status; > > > } > > > > > > +static uint16_t nvme_map(NvmeCtrl *n, NvmeCmd *cmd, size_t len, > > > + NvmeRequest *req) > > > > Can we specify what is going to be mapped in this function? like > > nvme_map_dptr? > I also once complained about the name, and I do like this idea! >
Hehe. I will change it ;) Note that when I post support for metadata, it will have to change again! Because then the function will be mapping both DPTR and MPTR. But lets discuss naming when we get to that ;)
