On 28.07.2020 14:36, Vladimir Sementsov-Ogievskiy wrote:
17.07.2020 11:14, Andrey Shinkevich wrote:
Per original script design, QcowHeader class may dump the QCOW2 header
info separately from the QCOW2 extensions info. To implement the
to_dict() method for dumping extensions, let us introduce the class
Qcow2HeaderExtensionsDoc.

I think, when dumping to qcow2, no needs to omit extensions, let's just always dump them.


Signed-off-by: Andrey Shinkevich <andrey.shinkev...@virtuozzo.com>
---
  tests/qemu-iotests/qcow2_format.py | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/tests/qemu-iotests/qcow2_format.py b/tests/qemu-iotests/qcow2_format.py
index 19d29b8..d2a8659 100644
--- a/tests/qemu-iotests/qcow2_format.py
+++ b/tests/qemu-iotests/qcow2_format.py
@@ -248,6 +248,15 @@ class Qcow2BitmapTable:
          return dict(entries=self.entries)
    +class Qcow2HeaderExtensionsDoc:
+
+    def __init__(self, extensions):
+        self.extensions = extensions
+
+    def to_dict(self):
+        return dict(Header_extensions=self.extensions)

s/H/h/


Sorry. I ment the non-JSON format dump as the original capitalized 'H'. The class Qcow2HeaderExtensionsDoc has been removed in the next v12.

Andrey


+
+
  QCOW2_EXT_MAGIC_BITMAPS = 0x23852875





Reply via email to