Hi,
I went ahead and pushed the series with the exception of this patch
and 14/15 because I think these are the types of patches that should
remain in downstream as a reminder, is there an argument for not
fixing these things in Linux?
In patch 04 I renamed omap2_gpio_module_set to omap2_gpio_set because
the parameter is no longer the module pointer. By the way I think we
should also pass the target agent pointer on creation the same way
clocks are passed and use omap_l4_attach.
In patch 07 I bumped the vmstate version because the structure seems
to have changed.
In patch 12 I removed the
else {
s->bdrv_cur = s->bdrv;
} part because there seemed to be no reason to add it, please check
that I haven't broken something.
Cheers
On 29 July 2011 17:35, Peter Maydell <peter.mayd...@linaro.org> wrote:
> Don't complain about some writes to r/o OMAP2 GPIO registers, because the
> kernel will do them anyway.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> hw/omap_gpio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/omap_gpio.c b/hw/omap_gpio.c
> index 478f7d9..b53b13b 100644
> --- a/hw/omap_gpio.c
> +++ b/hw/omap_gpio.c
> @@ -385,7 +385,7 @@ static void omap2_gpio_module_write(void *opaque,
> target_phys_addr_t addr,
> case 0x00: /* GPIO_REVISION */
> case 0x14: /* GPIO_SYSSTATUS */
> case 0x38: /* GPIO_DATAIN */
> - OMAP_RO_REG(addr);
> + /* read-only, ignore quietly */
> break;
>
> case 0x10: /* GPIO_SYSCONFIG */
> @@ -531,7 +531,7 @@ static void omap2_gpio_module_writep(void *opaque,
> target_phys_addr_t addr,
> case 0x00: /* GPIO_REVISION */
> case 0x14: /* GPIO_SYSSTATUS */
> case 0x38: /* GPIO_DATAIN */
> - OMAP_RO_REG(addr);
> + /* read-only, ignore quietly */
> break;
>
> case 0x10: /* GPIO_SYSCONFIG */
> --
> 1.7.1
>
>
