On 03/08/20 11:05, Claudio Fontana wrote: > 1) make icount TCG-only (building the icount module only under > CONFIG_TCG), as this series suggests, and provide a separate virtual > counter for qtest, > > > or > > > 2) continue to keep icount functions and fields, including vmstate, > in all softmmu builds because of qtest current use of field > qemu_icount_bias to implement its virtual counter for qtest_clock_warp? > > > If I understand correctly Paolo might be for 2) (?)
I am for (1), but using function pointers and not extra "if"s. I quickly skimmed this patchset and it seems to DTRT; we could get into huge discussions on how to organize the sers, but let's just not do that. :) Paolo
