On 06/08/20 18:11, Robert Foley wrote: >> Indeed the series should be structured like this: >> >> 1) rename all *_do_interrupt functions to *_do_interrupt_locked >> >> 2) add back *_do_interrupt that takes the BQL and calls >> *_do_interrupt_locked, point ->do_interrupt to it, remove the BQL from >> cpu-exec.c >> >> 3) modify the cpu_mutex and BQL critical sections around >> ->cpu_exec_interrupt, so that the BQL critical section covers just the >> call to ->cpu_exec_interrupt. Document which fields are now covered by >> cpu_mutex. >> >> 4/5) same as 1/2 for ->cpu_exec_interrupt >> >> Patches 1/2 would be pretty large, but they're trivial to review just by >> grepping for "->do_interrupt\s*=", and likewise for 4/5. >> > > Thanks for the details ! > > It seems like we will have 3 separate patches for this series, 1/2, 3, and > 4/5.
No, five patches. :) Paolo