No, the ext ID wasn't be checked at a real HW. Just copied it from the U-boot official repository https://github.com/u-boot/u-boot/blob/789bfb52668ee609b2043de645e2f94bbd24fd1f/drivers/mtd/spi/spi-nor-ids.c#L183
Do i need to take it from a real HW and compare? On 12.08.2020 10:27, Cédric Le Goater wrote: > On 8/11/20 10:37 PM, Igor Kononenko wrote: >> Support a following SPI flashes: >> * mx66l51235f >> * mt25ql512ab >> >> Signed-off-by: Igor Kononenko <i.konone...@yadro.com> >> --- >> hw/block/m25p80.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >> index 8227088441..bf1f833784 100644 >> --- a/hw/block/m25p80.c >> +++ b/hw/block/m25p80.c >> @@ -219,6 +219,7 @@ static const FlashPartInfo known_devices[] = { >> { INFO("mx25l12855e", 0xc22618, 0, 64 << 10, 256, 0) }, >> { INFO("mx25l25635e", 0xc22019, 0, 64 << 10, 512, 0) }, >> { INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) }, >> + { INFO("mx66l51235f", 0xc2201a, 0, 64 << 10, 1024, ER_4K | >> ER_32K) }, >> { INFO("mx66u51235f", 0xc2253a, 0, 64 << 10, 1024, ER_4K | >> ER_32K) }, >> { INFO("mx66u1g45g", 0xc2253b, 0, 64 << 10, 2048, ER_4K | >> ER_32K) }, >> { INFO("mx66l1g45g", 0xc2201b, 0, 64 << 10, 2048, ER_4K | >> ER_32K) }, >> @@ -237,6 +238,7 @@ static const FlashPartInfo known_devices[] = { >> { INFO("n25q128", 0x20ba18, 0, 64 << 10, 256, 0) }, >> { INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) }, >> { INFO("n25q512a", 0x20ba20, 0, 64 << 10, 1024, ER_4K) }, >> + { INFO("mt25ql512ab", 0x20ba20, 0x1044, 64 << 10, 1024, ER_4K | ER_32K) >> }, > > Have checked the extended ID on real HW ? > > C. > >> { INFO_STACKED("n25q00", 0x20ba21, 0x1000, 64 << 10, 2048, ER_4K, 4) >> }, >> { INFO_STACKED("n25q00a", 0x20bb21, 0x1000, 64 << 10, 2048, ER_4K, 4) >> }, >> { INFO_STACKED("mt25ql01g", 0x20ba21, 0x1040, 64 << 10, 2048, ER_4K, 2) >> }, >> > -- best, Igor Kononenko