Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> This makes secondary_cpu_reset() unnecessary, so remove it. >> >> Also remove setting of cs->halted from cpu_devinit(), which seems out of >> place when compared to similar code in other architectures (e.g., >> ppce500_init() in hw/ppc/e500.c). >> >> Finally, change creation of CPU object from cpu_create() to object_new() >> and qdev_realize_and_unref() because cpu_create() realizes the CPU and it's >> not possible to set a property after the object is realized. >> >> Suggested-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> Signed-off-by: Thiago Jung Bauermann <bauer...@linux.ibm.com> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks! -- Thiago Jung Bauermann IBM Linux Technology Center
