On Thu, Aug 20, 2020 at 04:06:35PM -0300, Daniel Henrique Barboza wrote: > We do not implement hotplug in the vscsi bus, but we forgot to > tell qdev about it. The result is that users are able to hotplug > devices in the vscsi bus, the devices appear in qdev, but they > aren't usable by the guest OS unless the user reboots it first. > > Setting qbus hotplug_handler to NULL will tell qdev-monitor, via > qbus_is_hotpluggable(), that we do not support hotplug operations > in spapr_vscsi. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1862059 > > Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com>
That was much easier than I feared. Nice!
Applied to ppc-for-5.2.
> ---
> hw/scsi/spapr_vscsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> index d17dc03c73..57f0a1336f 100644
> --- a/hw/scsi/spapr_vscsi.c
> +++ b/hw/scsi/spapr_vscsi.c
> @@ -1219,6 +1219,9 @@ static void spapr_vscsi_realize(SpaprVioDevice *dev,
> Error **errp)
>
> scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(dev),
> &vscsi_scsi_info, NULL);
> +
> + /* ibmvscsi SCSI bus does not allow hotplug. */
> + qbus_set_hotplug_handler(BUS(&s->bus), NULL);
> }
>
> void spapr_vscsi_create(SpaprVioBus *bus)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
