On Sat, 22 Aug 2020 at 16:05, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > Most uses of qemu_hexdump() do not take an array of char > as input, forcing use of cast. Since we can use this > helper to dump any kind of buffer, use a pointer to void > argument instead. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> -void qemu_hexdump(const char *buf, FILE *fp, const char *prefix, size_t > size); > +void qemu_hexdump(const void *ptr, FILE *fp, const char *prefix, size_t > size); Changing the type seems reasonable, but it is still a pointer to a buffer, so I think keeping the name 'buf' is more descriptive. As an aside, is it just me that finds the order of arguments here a bit odd? The pointer to the buffer and the length of the buffer are closely related arguments that are widely separated in the argument list order, and the FILE* that you might expect to come first doesn't. "fp, prefix, buf, size" would seem more logical. Not sure it's worth the effort of changing, though... thanks -- PMM
