On 8/18/20 8:50 AM, Taylor Simpson wrote: > +#define ATTRIB_WIDTH 32 > +#define GET_ATTRIB(opcode, attrib) \ > + (((opcode_attribs[opcode][attrib / ATTRIB_WIDTH])\ > + >> (attrib % ATTRIB_WIDTH)) & 0x1)
Can you define GET_ATTRIB in terms of qemu/bitops.h? I'm leery of ATTRIB_WIDTH being separate from the actual definition of opcode_attribs, over in opcodes.h. Why does attribs.h need to live separately? They're clearly closely related, and cannot in fact be used separately. r~
