On Tue, 25 Aug 2020 at 19:14, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 8/24/20 7:29 AM, Peter Maydell wrote: > > +DEF_HELPER_3(vfp_addh, f32, f32, f32, ptr) > > We do have an f16 entry in helper-head.h, for documentation purposes. It > expands to the same uint32_t, so it doesn't make any practical difference. > > > > +float32 VFP_HELPER(name, h)(float32 a, float32 b, void *fpstp) \ > > And here it would be better to use uint32_t explicitly, because we're > definitely not returning float32. > > I guess you could see if dh_ctype_f16 works here? But that looks a bit ugly > to > me. Perhaps we should have introduced a better typedef somewhere...
dh_ctype_f16 does work, yes. Unless you can think of a better name I think we should go with using that. I'm not sure that "16 bit float held in a 32-bit unsigned integer for the benefit of the TCG calling convention" is ever going to have a particularly snappy name... thanks -- PMM
