On 25/08/20 10:11, Marc-André Lureau wrote: > > As far I know make doesn't redirect output. Or maybe it redirects using > a pty (instead of a pipe) in case stdout is a terminal. At least auto > mode for colored gcc warnings works fine with make. It is colored when > started in a terminal, it isn't when started in emacs (and piped through > the emacs message parser). > > Then it looks like you have a legit patch. We can revert it when we > switch back to ninja some day. > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com > <mailto:marcandre.lur...@redhat.com>> >
make has the same issue if you use -O/--output-sync. Programs are supposed to check MAKE_TERMOUT and MAKE_TERMERR to decide whether to colorize output, but I think pretty much no one does? In any case this would not be a new issue, so b_colorout=auto is preferrable. Paolo
