On Thu, 27 Aug 2020 at 15:29, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > The compiler encounters trace event format strings in generated code. > Format strings are error-prone and therefore clear compiler errors are > important. > > Use the #line directive to show the trace-events filename and line > number in format string errors: > https://gcc.gnu.org/onlinedocs/gcc-10.2.0/cpp/Line-Control.html > > For example, if the cpu_in trace event's %u is changed to %p the > following error is reported: > > trace-events:29:18: error: format ‘%p’ expects argument of type ‘void *’, > but argument 7 has type ‘unsigned int’ [-Werror=format=] > > Line 29 in trace-events is where cpu_in is defined. This works for any > trace-events file in the QEMU source tree and the correct path is > displayed. > > Unfortunately there does not seem to be a way to set the column, so "18" > is not the right character on that line. > > Suggested-by: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > ---
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
