On 31 July 2011 22:40, Johannes Schauer <j.scha...@email.de> wrote: > Rework option parsing code for linux-user in a table-driven manner to allow > environment variables for all commandline options. > > Also generate usage() output from option table.
Thanks for this, it looks good. A couple of minor points: (1) what's the rationale for having most of the things the arg-parsing-functions change be global variables but passing envlist as an argument to each function? It's only used by two of the functions so maybe that should just be a global too. (2) scripts/checkpatch.pl complains about a number of formatting nits; mostly these are in existing code you've just moved around, but I think it's worth fixing them in passing anyway. -- PMM
