On 9/3/20 8:22 AM, Daniel P. Berrangé wrote: > Currently code has to call monitor_fdset_get_fd, then dup > the return fd, and then add the duplicate FD back into the > fdset. This dance is overly verbose for the caller and > introduces extra failure modes which can be avoided by > folding all the logic into monitor_fdset_dup_fd_add and > removing monitor_fdset_get_fd entirely. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > include/monitor/monitor.h | 3 +- > include/qemu/osdep.h | 1 + > monitor/misc.c | 58 +++++++++++++++++---------------------- > stubs/fdset.c | 8 ++---- > util/osdep.c | 19 ++----------- > 5 files changed, 32 insertions(+), 57 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
