On Fri, Sep 04, 2020 at 12:08:23PM -0700, Richard Henderson wrote: > Version 3: > > * Splits out MicroBlazeCPUConfig, and moves some values > out of CPUMBState (env) that are constant configuration > parameters, or derived from configuration parameters. > > * Do not save configuration parameters with vmstate. > * Pass around MicroBlazeCPUConfig in the translator. > * Do not set TARGET_ABI32 in configure. > > Version 2: > > * Includes fixes for iflags that could cause lockups. > > It seems it was easier to do so with icount=7, which is what we > do during the replay acceptance tests. This causes TBs to contain > no more than 7 insns, and often less to make up for an incomplete > count elsewhere. Which stressed the iflags bits around delay slots > and imm in ways that pure single-step doesn't. > > * cpu vmstate is filled in > * interrupt logging is tidied. > > > r~
Looks good, none of the test issues were relatd. Thanks Richard! On all the patches I had not previously reviewed: Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Tested-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Can you take the pull-req via your trees? Cheers, Edgar