On Thu, Sep 10, 2020 at 06:32:28PM +0200, Philippe Mathieu-Daudé wrote: > +GitLab team & Gerd (for building firmwares) > > On 9/8/20 9:29 AM, Laszlo Ersek wrote:
> Now I remember why I kept that patch on hold. > > The CI idea is to have reproducible builds if possible. NB it isn't going to eb truly reproducible because the docker env we're building in is liable to change each time we run it, either because we've updated the base OS, or "apt update" pulls in different content set. At the least, we should likely record the full set of packages installed in the container, alongside the blob in qemu.git, so we have a strong record of the toolchain used. > When the submodule is updated (or the QEMU scripts containing the > -D defines), it triggers the 'build-edk2' job which produce these > same binaries. > My original idea was to push the tag on GitLab that triggers the > job, then download the produced binaries, test them, then commit > them. > > With your series, I get these binaries: > https://gitlab.com/philmd/qemu/-/jobs/731618363/artifacts/browse/pc-bios/ > > However they differ with yours, for example: > > 0000 6100: 00 00 00 00 00 00 00 00 00 00 00 00 2F 68 6F 6D ........ > ..../hom > 0000 6110: 65 2F 6C 61 63 6F 73 2F 73 72 63 2F 75 70 73 74 e/lacos/ > src/upst > 0000 6120: 72 65 61 6D 2F 71 65 6D 75 2F 72 6F 6D 73 2F 65 ream/qem > u/roms/e > 0000 6130: 64 6B 32 2F 42 75 69 6C 64 2F 41 72 6D 56 69 72 dk2/Buil > d/ArmVir > 0000 6140: 74 51 65 6D 75 2D 41 41 52 43 48 36 34 2F 44 45 tQemu-AA > RCH64/DE > 0000 6150: 42 55 47 5F 47 43 43 35 2F 41 41 52 43 48 36 34 BUG_GCC5 > /AARCH64 > 0000 6160: 2F 41 72 6D 50 6C 61 74 66 6F 72 6D 50 6B 67 2F /ArmPlat > formPkg/ > 0000 6170: 50 72 65 50 65 69 43 6F 72 65 2F 50 72 65 50 65 PrePeiCo > re/PrePe > 0000 6180: 69 43 6F 72 65 55 6E 69 43 6F 72 65 2F 44 45 42 iCoreUni > Core/DEB > 0000 6190: 55 47 2F 41 72 6D 50 6C 61 74 66 6F 72 6D 50 72 UG/ArmPl > atformPr > 0000 61A0: 65 50 65 69 43 6F 72 65 2E 64 6C 6C 00 00 00 00 ePeiCore > .dll.... > > 0000 6100: 00 00 00 00 00 00 00 00 00 00 00 00 2F 62 75 69 ........ > ..../bui > 0000 6110: 6C 64 73 2F 70 68 69 6C 6D 64 2F 71 65 6D 75 2F lds/phil > md/qemu/ > 0000 6120: 72 6F 6D 73 2F 65 64 6B 32 2F 42 75 69 6C 64 2F roms/edk > 2/Build/ > 0000 6130: 41 72 6D 56 69 72 74 51 65 6D 75 2D 41 41 52 43 ArmVirtQ > emu-AARC > 0000 6140: 48 36 34 2F 44 45 42 55 47 5F 47 43 43 35 2F 41 H64/DEBU > G_GCC5/A > 0000 6150: 41 52 43 48 36 34 2F 41 72 6D 50 6C 61 74 66 6F ARCH64/A > rmPlatfo > 0000 6160: 72 6D 50 6B 67 2F 50 72 65 50 65 69 43 6F 72 65 rmPkg/Pr > ePeiCore > 0000 6170: 2F 50 72 65 50 65 69 43 6F 72 65 55 6E 69 43 6F /PrePeiC > oreUniCo > 0000 6180: 72 65 2F 44 45 42 55 47 2F 41 72 6D 50 6C 61 74 re/DEBUG > /ArmPlat > 0000 6190: 66 6F 72 6D 50 72 65 50 65 69 43 6F 72 65 2E 64 formPreP > eiCore.d > 0000 61A0: 6C 6C 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ll...... > ........ > > For now this is not a blocker, but we should consider switching to > this workflow at some point (caring about all the files that really > need to be archived, maybe debug symbols etc...). > > w.r.t. your patch: > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Regards, > > Phil. > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
