On 9/11/20 2:18 PM, Thomas Huth wrote: > Let's make this file compilable with -Werror=implicit-fallthrough : > Looking at the code, it seems like the fallthrough is intended here, > so we should add the corresponding "/* fallthrough */" comment here. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > hw/arm/pxa2xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c > index 76975d17a4..c1f45b2adf 100644 > --- a/hw/arm/pxa2xx.c > +++ b/hw/arm/pxa2xx.c > @@ -443,7 +443,7 @@ static void pxa2xx_mm_write(void *opaque, hwaddr addr, > s->mm_regs[addr >> 2] = value; > break; > } > - > + /* fallthrough */ > default: > qemu_log_mask(LOG_GUEST_ERROR, > "%s: Bad write offset 0x%"HWADDR_PRIx"\n", >
I keep rebasing this one from Stefan, not sure why never upstreamed :/ https://repo.or.cz/qemu/ar7.git/blobdiff/2a9c928409..5ebb514633:/hw/arm/pxa2xx.c Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>
