On 9/13/20 5:01 PM, Richard Henderson wrote:
> case "$capstone" in
> - git | internal)
> + git)
> if test "$capstone" = git; then
> git_submodules="${git_submodules} capstone"
> fi
The if here can be removed now. Alternately...
> - mkdir -p capstone
> - if test "$mingw32" = "yes"; then
> - LIBCAPSTONE=capstone.lib
> - else
> - LIBCAPSTONE=libcapstone.a
> - fi
> - capstone_libs="-Lcapstone -lcapstone"
> - capstone_cflags="-I${source_path}/capstone/include"
> ;;
>
> - system)
> - capstone_libs="$($pkg_config --libs capstone)"
> - capstone_cflags="$($pkg_config --cflags capstone)"
> + internal | system | no)
> ;;
>
> - no)
> - ;;
> *)
> error_exit "Unknown state for capstone: $capstone"
> ;;
... stop trying to validate the set of states and instead remove the outer
case, leaving only the inner if.
Thoughts?
r~
