Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

[David Hildenbrand]

> Am 14.09.2020 um 11:42 schrieb Philippe Mathieu-Daudé <phi...@redhat.com>:
> 
> +Laurent and David
> 
>> On 9/14/20 11:16 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <phi...@redhat.com> writes:
>> 
>>> Only qemu-system-FOO and qemu-storage-daemon provide QMP
>>> monitors, therefore such declarations and definitions are
>>> irrelevant for user-mode emulation.
>>> 
>>> Restricting the balloon-related commands to machine.json
>>> allows pulling less declarations/definitions to user-mode.
>> 
>> How this affects user mode is not obvious to (ignorant) me.  Can you
>> provide a clue?
> 
> I guess this was discussed with David at some point.
> 
> Maybe the QMP commands are not exposed via HMP, making this
> code unreachable?
> 
> Anyhow user-mode binaries don't use the memory ballooning feature,
> this is specific to system-mode emulation.
> 
> Laurent/David, do you have some more trivial explanation?

Agreed.

No memory ballooning device -> no memory ballooning :)

> 
> Thanks,
> 
> Phil.
>