On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/17/20 7:02 PM, Stefano Garzarella wrote:
> > Running checkpatch on a directory that contains a cover letter reports
> > this error:
> >
> > Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
> > ERROR: Does not appear to be a unified-diff format patch
> >
> > total: 1 errors, 0 warnings, 0 lines checked
> >
> > Let's skip cover letter as it is already done in the Linux kernel.
>
> .. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
> on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
> ignoring cover-letter logic")."
>
> Maybe complete with that ^^^ ?
Yes, it's better ;-)
Should I send a v2 or can be updated when queueing?
>
> Regardless:
> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Thanks!
Stefano
